Open
Conversation
Greptile SummaryThis PR adds the Leopard brand logo and favicon set — replacing the placeholder "L" text block on the landing page with a new Key observations:
Confidence Score: 3/5
Important Files Changed
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/nextjs/src/components/leopard-logo.tsx
Line: 32-34
Comment:
**Red debug stroke left in SVG**
The path inside the `mask0_205_66` mask element has `stroke="#FF0000"` and `strokeWidth="2"`, which is a classic Figma "debug outline" artifact. Because the parent mask uses `maskType: "alpha"`, the red color itself doesn't affect visible output (alpha is what drives the mask, and red is fully opaque just like white). However, this is unexpectedly left in the SVG source and will confuse anyone reading or editing this file. The same red stroke is also present in `apps/nextjs/src/app/icon0.svg` (line 8) and should be removed from both assets.
```suggestion
fill="#FFFEFE"
strokeWidth="2"
mask="url(#path-3-inside-1_205_66)"
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/nextjs/src/app/page.tsx
Line: 33-35
Comment:
**Component integrated in same PR as its creation**
`LeopardLogo` is both created (`src/components/leopard-logo.tsx`) and wired into the main landing page in this single PR. Per project convention, components should be developed in isolation and integrated into pages in a separate, follow-up PR. This makes each change independently reviewable and revertable.
**Rule Used:** Keep PRs focused on individual components without ... ([source](https://app.greptile.com/review/custom-context?memory=1468e328-08d6-42d6-9f09-f6b8b663275a))
**Learnt From**
[deltahacks/landing-12#12](https://github.com/deltahacks/landing-12/pull/12)
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/nextjs/src/components/leopard-logo.tsx
Line: 20
Comment:
**Inline style on SVG mask element**
`style={{ maskType: "alpha" }}` is an inline style. The project rule prefers Tailwind CSS classes over inline styles. While `mask-type` has no direct Tailwind utility, you can express it via an arbitrary CSS property using Tailwind's `[mask-type:alpha]` syntax:
```suggestion
className="[mask-type:alpha]"
maskUnits="userSpaceOnUse"
```
**Rule Used:** Use Tailwind CSS classes instead of inline styles ... ([source](https://app.greptile.com/review/custom-context?memory=0b2b635d-cbb8-42e2-a38c-193803fa0968))
**Learnt From**
[deltahacks/landing-12#12](https://github.com/deltahacks/landing-12/pull/12)
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat: add logo and favicon" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+32
to
+34
| fill="#FFFEFE" | ||
| stroke="#FF0000" | ||
| strokeWidth="2" |
There was a problem hiding this comment.
The path inside the mask0_205_66 mask element has stroke="#FF0000" and strokeWidth="2", which is a classic Figma "debug outline" artifact. Because the parent mask uses maskType: "alpha", the red color itself doesn't affect visible output (alpha is what drives the mask, and red is fully opaque just like white). However, this is unexpectedly left in the SVG source and will confuse anyone reading or editing this file. The same red stroke is also present in apps/nextjs/src/app/icon0.svg (line 8) and should be removed from both assets.
Suggested change
| fill="#FFFEFE" | |
| stroke="#FF0000" | |
| strokeWidth="2" | |
| fill="#FFFEFE" | |
| strokeWidth="2" | |
| mask="url(#path-3-inside-1_205_66)" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/nextjs/src/components/leopard-logo.tsx
Line: 32-34
Comment:
**Red debug stroke left in SVG**
The path inside the `mask0_205_66` mask element has `stroke="#FF0000"` and `strokeWidth="2"`, which is a classic Figma "debug outline" artifact. Because the parent mask uses `maskType: "alpha"`, the red color itself doesn't affect visible output (alpha is what drives the mask, and red is fully opaque just like white). However, this is unexpectedly left in the SVG source and will confuse anyone reading or editing this file. The same red stroke is also present in `apps/nextjs/src/app/icon0.svg` (line 8) and should be removed from both assets.
```suggestion
fill="#FFFEFE"
strokeWidth="2"
mask="url(#path-3-inside-1_205_66)"
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+33
to
35
| <div className="w-15 overflow-hidden rounded-lg"> | ||
| <LeopardLogo className="h-full w-full" /> | ||
| </div> |
There was a problem hiding this comment.
LeopardLogo is both created (src/components/leopard-logo.tsx) and wired into the main landing page in this single PR. Per project convention, components should be developed in isolation and integrated into pages in a separate, follow-up PR. This makes each change independently reviewable and revertable.
Rule Used: Keep PRs focused on individual components without ... (source)
Learnt From
deltahacks/landing-12#12
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/nextjs/src/app/page.tsx
Line: 33-35
Comment:
**Component integrated in same PR as its creation**
`LeopardLogo` is both created (`src/components/leopard-logo.tsx`) and wired into the main landing page in this single PR. Per project convention, components should be developed in isolation and integrated into pages in a separate, follow-up PR. This makes each change independently reviewable and revertable.
**Rule Used:** Keep PRs focused on individual components without ... ([source](https://app.greptile.com/review/custom-context?memory=1468e328-08d6-42d6-9f09-f6b8b663275a))
**Learnt From**
[deltahacks/landing-12#12](https://github.com/deltahacks/landing-12/pull/12)
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| /> | ||
| <mask | ||
| id="mask0_205_66" | ||
| style={{ maskType: "alpha" }} |
There was a problem hiding this comment.
style={{ maskType: "alpha" }} is an inline style. The project rule prefers Tailwind CSS classes over inline styles. While mask-type has no direct Tailwind utility, you can express it via an arbitrary CSS property using Tailwind's [mask-type:alpha] syntax:
Suggested change
| style={{ maskType: "alpha" }} | |
| className="[mask-type:alpha]" | |
| maskUnits="userSpaceOnUse" |
Rule Used: Use Tailwind CSS classes instead of inline styles ... (source)
Learnt From
deltahacks/landing-12#12
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/nextjs/src/components/leopard-logo.tsx
Line: 20
Comment:
**Inline style on SVG mask element**
`style={{ maskType: "alpha" }}` is an inline style. The project rule prefers Tailwind CSS classes over inline styles. While `mask-type` has no direct Tailwind utility, you can express it via an arbitrary CSS property using Tailwind's `[mask-type:alpha]` syntax:
```suggestion
className="[mask-type:alpha]"
maskUnits="userSpaceOnUse"
```
**Rule Used:** Use Tailwind CSS classes instead of inline styles ... ([source](https://app.greptile.com/review/custom-context?memory=0b2b635d-cbb8-42e2-a38c-193803fa0968))
**Learnt From**
[deltahacks/landing-12#12](https://github.com/deltahacks/landing-12/pull/12)
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.